chore(readme): Enclose URL in Quotes#36
Open
Jannchie wants to merge 3 commits intocumulo-autumn:mainfrom
Open
Conversation
Owner
|
Thank you for pointing out that problem and suggesting enclosing the entire URL in quotes which accommodates both environments. However, since quotes are not commonly used in regular pip installations, I am a bit concerned that it might actually confuse people who don't usually use zsh. I am thinking about what to do with the README. Perhaps, it would be a good idea to add a separate note suggesting to try using quotes if the installation doesn't go smoothly. This is quite a subjective matter, so it's a bit difficult to decide. I'll think about it a bit more before making a decision. Anyway, thank you very much for your feedback and the suggestion for improvement! |
Coinbitstarhydro
approved these changes
Jan 13, 2024
| pip install git+https://github.com/cumulo-autumn/StreamDiffusion.git@main#egg=streamdiffusion[tensorrt] | ||
| pip install "git+https://github.com/cumulo-autumn/StreamDiffusion.git@main#egg=streamdiffusion[tensorrt]" | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this amazing work!
I am trying to install this package from a Git repository using pip with zsh. The error message zsh: no matches found typically occurs in the Z shell (zsh) when it tries to interpret special characters. In the command, the square brackets ([]) are likely causing the issue, as zsh treats them as a pattern-matching character.
To fix this, we can either escape the square brackets or enclose the entire URL in quotes.
This change does not affect
bashusers and is compatible withzshusers.Related stackoverflow link: https://stackoverflow.com/a/30539963/8625892